Skip to content

Conversation

DarylThayil
Copy link

@DarylThayil DarylThayil commented Jul 7, 2018

Lets us take advantage of the ReactDOM.hydrate method.

  • add tests for render / hydrate render method
  • add jsdom so we can test browser

@DarylThayil
Copy link
Author

@pwmckenna can I get a review :)

@DarylThayil
Copy link
Author

closes #137

Lets us take advantage of the ReactDOM.hydrate method
@DarylThayil
Copy link
Author

I spoke to @pwmckenna

feedback was
[ ] 1 pr for tests a separate pr for hydrate
[ ] rename hydrate render to just be hydrate
[ ] dont bump peer deps to require react 16, instead have hydrate function check for hydrate funciton in reactdom and if it s not available, either throw error or fallback to render (id probably throw?)

@DarylThayil
Copy link
Author

@monder any feedback?

@viveksanthosh
Copy link

viveksanthosh commented Aug 26, 2018

Hey @DarylThayil I have raised a pull request on your fork of this repo upgrading babel to babel-cli.
DarylThayil#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants