Skip to content

Conversation

@samfoo
Copy link

@samfoo samfoo commented Dec 29, 2014

fail! has been deprecated in favour of panic! (see rust issues 17489).

This is just s/fail!/panic!/g

@samfoo
Copy link
Author

samfoo commented Dec 29, 2014

A few more updates:

  • Changed all int's that are used for pointer indices to uint's
  • Changed indexing in data from data[i] to data.as_bytes[i].

The second change worries me a bit. I don't understand ragel well enough to know how it handles unicode... I suspect this was an existing bug though, since the old data[i] had the same behavior...

* index int's -> uint's
* index into &str with .as_bytes[i] instead of [i] (does this break unicode?)
* give `_goto_targ` a type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant