Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added prerequisites to readme :) #5

Closed
wants to merge 2 commits into from

Conversation

thundergreen
Copy link
Contributor

No description provided.

Copy link
Owner

@ericmatte ericmatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR :)
I will merge it once these comments will be fixed.

@@ -1,4 +1,28 @@
This appdaemon app allows rgb lights to be synced with the thumbnail of a media player in Home Assistant.
# Prerequsites
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Suggested change
# Prerequsites
# Prerequisites

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I would like this whole section to be under # Configuration with heading-2 (## Prerequisites).


- python pillow

To install Python Pillow Package, please install either the way described below.If you are running Hassio Addon you must add those package manually in the AppDaemon-Config:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To install Python Pillow Package, please install either the way described below.If you are running Hassio Addon you must add those package manually in the AppDaemon-Config:
To install the Python Pillow Package, please install either the way described below.
If you are running Hass.io addon, you must add those packages manually in the `AppDaemon-Config`:

Comment on lines +9 to +25
```
system_packages:
- gcc
- libgcc
- musl-dev
- jpeg-dev
- zlib-dev
- libjpeg
- tiff
- gcc
- python3-dev
- musl-dev
python_packages:
- Pillow
init_commands: []
disable_auto_token: true
log_level: info
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no closing section markers: ```

@ericmatte
Copy link
Owner

Closing as the project for tv lights sync has been moved into it's own repository: https://github.com/ericmatte/ad-media-lights-sync

@ericmatte ericmatte closed this Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants