Skip to content

Conversation

@bigmoonbit
Copy link
Contributor

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

Inspired by #17403 and replace all

@bigmoonbit
Copy link
Contributor Author

I have added the corresponding logic to ensure that when 'sub' is empty, it is treated as a wildcard.

Do I need to squash the two commits into one? Thank you for your review!

@taratorio
Copy link
Member

I have added the corresponding logic to ensure that when 'sub' is empty, it is treated as a wildcard.

Do I need to squash the two commits into one? Thank you for your review!

no, all good - it will be squashed automatically when we merge it

taratorio
taratorio previously approved these changes Dec 5, 2025
@taratorio taratorio enabled auto-merge (squash) December 5, 2025 08:18
@taratorio
Copy link
Member

@bigmoonbit lint seems to be failing, can you please fix it and ill re-approve?

auto-merge was automatically disabled December 5, 2025 08:51

Head branch was pushed to by a user without write access

@bigmoonbit
Copy link
Contributor Author

@bigmoonbit lint seems to be failing, can you please fix it and ill re-approve?

@taratorio Modified. It seems to be because of an extra space.

Please review it again.

image

@taratorio
Copy link
Member

@bigmoonbit lint seems to be failing, can you please fix it and ill re-approve?

@taratorio Modified. It seems to be because of an extra space.

Please review it again.

image

thank you

@taratorio taratorio enabled auto-merge (squash) December 5, 2025 10:46
@taratorio taratorio merged commit 2032a86 into erigontech:main Dec 5, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants