Re-run installation_history widen for pre-v2.7.0 no-op upgrades (#828)#936
Merged
Conversation
Servers that crossed 2.4 -> 2.5 before PR #828's USE-statement fix shipped in v2.7.0 ran the widen script as a no-op against master and advanced their installer_version past 2.5. The upgrade filter (ToVersion > current) then permanently skipped the now-fixed script, leaving sql_server_version and sql_server_edition stuck at nvarchar(255) -- which truncates SQL 2022+ @@Version strings (~260 chars) on every install attempt. Re-applies the same idempotent widen in 2.10.0-to-2.11.0 so any server upgrading to the next release picks it up. The IF EXISTS guards on max_length = 510 mean already-widened servers skip both ALTERs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upgrades/2.10.0-to-2.11.0/01_rewiden_version_columns.sqlto re-run the installation_history version-column widening for servers stranded by the original [BUG] Installation History - Truncation Error #828 bug.USE PerformanceMonitor;(fixed in [BUG] Installation History - Truncation Error #828, shipped v2.7.0). Servers that crossed 2.4 → 2.5 before v2.7.0 silently no-op'd the ALTERs againstmaster, advanced past 2.5, and the upgrade filter (ToVersion > currentVersion) permanently skips the now-fixed script. Result:sql_server_version/sql_server_editionstay atnvarchar(255)and truncate SQL 2022+@@VERSIONstrings (~260 chars).IF EXISTS … max_length = 510guards skip already-widened servers.ghauanon [BUG] Installation History - Truncation Error #828 hitting this on a SQL 2025 server upgrading 2.8 → 2.10. Issue stays closed; commented there.Test plan
nvarchar(255): run installer upgrade, confirm both columns becomenvarchar(512)and the install record inserts without truncation warning.upgrade.txtis picked up byScriptProvider.GetApplicableUpgradesfor current → 2.11.0 paths.🤖 Generated with Claude Code