[inets] Slave module deprecation: Replace slave with peer in code and comments #10064
Conversation
CT Test Results 2 files 23 suites 9m 37s ⏱️ Results for commit e37fa0e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
kvakvs
force-pushed
the
eimytdl/slave-to-peer-inets/OTP-19717
branch
from
93cddfa to
3fb955b
Compare
kvakvs
changed the title
kvakvs
added
team:PS
|
I think this is not a good example, I think we should move it all to test and remove this example directory (this is very legacy way to document something). If we need more examples we should aim to improve the users guide instead. I think we should discuss if this is something to be kept at all. I do not think it has been run in a long time. |
kvakvs
removed
the
testing
| @@ -139,7 +139,7 @@ start_node(Name) -> | |||
| end, | |||
| A = Args ++ " -pa " ++ Pa, | |||
| Opts = [{cleanup,false}, {args, A}], | |||
| case (catch test_server:start_node(Name, slave, Opts)) of | |||
There was a problem hiding this comment.
This function is not used and does not need to be keep. You could do a git grep on more functions here see which ones we should keep.
|
@kvakvs You removed to much. The httpd_bench_SUITE actually does not use legacy load tests and should not be removed. |
kvakvs
force-pushed
the
eimytdl/slave-to-peer-inets/OTP-19717
branch
from
610a145 to
c3531c7
Compare
IngelaAndin
changed the title
kvakvs
force-pushed
the
eimytdl/slave-to-peer-inets/OTP-19717
branch
from
18fca69 to
33bfdbc
Compare
kvakvs
force-pushed
the
eimytdl/slave-to-peer-inets/OTP-19717
branch
from
33bfdbc to
8c92c17
Compare
lib/inets/test/httpd_bench_SUITE.erl
Outdated
| {http_headers, [{"connection", "close"}]}, | ||
| {http_opts,[{version, Version}]}, | ||
| {httpc_opts, [{keep_alive_timeout, 0}, {max_keep_alive_length, 0}]} | ||
| | Config]); |
There was a problem hiding this comment.
This line is wrongly indented. Erlang mode for emacs indents it differently, that is there is one space too much (and was so from the start).
There was a problem hiding this comment.
This is not a well formalized requirement. I do not use Emacs, will never be using Emacs, and i have no way to know how the correct indentation would be. Is "Emacs formatter" a separate easy to install tool which can be used in the git precommit hook and in the CI to control the code indentation? Because other formatters, like erlfmt can be, and they solve a lot of these situations by applying same style formatting on all machines and can be called from any editor on save, too.
Inets
Summary of changes
slaveis removed from tests for inets, replaced with peerhttpd_bench_SUITEis passing again with HTTP and HTTPS casesCosmetic update for
httpd_bench_SUITEThe suite takes 58 seconds on my laptop (including nginx case) all cases run and succeed.
Not tested with cross-server benchmark where test peer starts elsewhere, it is controlled by an ENV option, but maybe it is not necessary if we enable it in all test runs?