[MacOS] [CI] wxWidgets source build errors

[kvakvs]

Problem

Compile errors appear when building wxWidgets on MacOS using .github/scripts/build-macos-wxwidgets.sh with latest Clang 17.

Solution

1. Replaced via sed: #include <fp.h> to #include <math.h> in the wxWidgets/src/png/pngpriv.h
2. Commented out via sed: #define fdopen in wxWidgets/src/zlib/zutil.h
3. Minor changes (addressing issues found in sh file by shellcheck tool).

Other Solutions

The problem caused by the changes in standard library in Clang 17. Alternative solution is installing and using previous Clang 16 via Homebrew or somehow else.

[github-actions]

CT Test Results

  1 files   11 suites   3m 52s ⏱️
 95 tests  91 ✅ 4 💤 0 ❌
111 runs  107 ✅ 4 💤 0 ❌

Results for commit 3b4ad7e.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• Windows Installer

// Erlang/OTP Github Action Bot

[kikofernandez]

I think this change sounds good.
I would wait for @dgud input, since he is the main maintainer of the wx app

[dgud]

I don't like patching wxWidgets, a better variant would be to use system png and zlib there are configure flags for that.
if system libraries for png and zlib exists.

[IngelaAndin]

Request changes a suggested by @dgud

[kvakvs]

Now it is just one line of change, i kept the download bit, but commented, and the option i removed is also commented. Local build succeeded. Will see what the CI has to say.

[kvakvs]

Apparently changing it to use system libraries and removing the patching did not work as expected, and there's fp.h include error again. Even if system libraries are possibly fixed, the build machine doesn't have them up to date.

[dgud]

It didn't use system libraries for png and jpeg :-(

configure: WARNING: system png library not found or too old, will use built-in instead
checking for png.h... (cached) no
checking whether png.c file exists... yes
configure: WARNING: system jpeg library not found, will use built-in instead
checking for jpeglib.h... no

[dgud]

Rebase to maint and squash commits

[kvakvs]

Source branch renamed, this now continues in #10239