ssh: adjust private key length for DH key generation #10380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
u3s
commented
Nov 17, 2025
u3s
commented
- if calculated private key length is equal or exceeds number of bits in P (PBits)
- use PBits - 1
Contributor
CT Test Results 2 files 29 suites 19m 24s ⏱️ Results for commit 676526e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
u3s
force-pushed
the
kuba/ssh/dh_genkey_pbits_minus_1
branch
from
e1720c9 to
93bb4b9
Compare
- if calculated private key length is equal or exceeds number of bits in P (PBits) - use PBits - 1
u3s
force-pushed
the
kuba/ssh/dh_genkey_pbits_minus_1
branch
from
93bb4b9 to
676526e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.