Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: Add behaviour to define callbacks for via registries #1982

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheFirstAvenger
Copy link

This new behaviour defines the three callbacks required for custom registries (i.e. {via, Module, Name}).

If accepted, and once added to bootstrap, a second PR will be added to add this behaviour to global.

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2018

CLA assistant check
All committers have signed the CLA.

@TheFirstAvenger TheFirstAvenger changed the title Add behaviour to define callbacks for via registries kernel: Add behaviour to define callbacks for via registries Oct 16, 2018
@sirihansen
Copy link
Contributor

I'm sorry for the delayed handling of this PR, and unfortunately I still have no answer. We need to discuss the way forward for behaviours in general before we can decide anything on this.

Thanks for you contribution!

@TheFirstAvenger
Copy link
Author

TheFirstAvenger commented Jan 9, 2019

@sirihansen thanks for the update! Is/Will this conversation be public. If so, where?

@sirihansen
Copy link
Contributor

At least as a start it will be an internal discussion, but we might involve the community at a later stage. If so, it will probably be on the erlang-questions mailing list.

@uabboli uabboli added team:VM Assigned to OTP team VM and removed team:MW labels Aug 21, 2019
@garazdawi garazdawi added the stalled waiting for input by the Erlang/OTP team label Aug 23, 2019
@github-actions
Copy link
Contributor

CT Test Results

Tests are running... https://github.com/erlang/otp/actions/runs/6500041326

Results for commit c251c30

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

  • No CT logs found
  • No HTML docs found
  • No Windows Installer found

// Erlang/OTP Github Action Bot

@TheFirstAvenger
Copy link
Author

@sirihansen Any update on this PR? It's the 5 year anniversary of it being submitted 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled waiting for input by the Erlang/OTP team team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants