Error message types #3045
Merged
Error message types #3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this pull request is still relevant, please rebase it on the latest master. |
richcarl
force-pushed
the
error-message-types
branch
2 times, most recently
from
c17bd14 to
c03f48a
Compare
|
Fixed now. |
|
There are failed test cases in the |
|
The types look good to me. |
richcarl
force-pushed
the
error-message-types
branch
from
c03f48a to
e990d49
Compare
|
Fixed test cases. |
bjorng
added
enhancement
testing
|
Thanks for your pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup based on #3020.
Makes the compiler use the type declarations in erl_lint as the source of truth for how errors and warnings are represented.
(A minor snag was that the core_lint pass returned a module name (an atom) as the "filename", and the file:filename() type doesn't officially include atoms even if they have always worked.