Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wx: Detect OpenGL for cross compilation #5769

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joaohf
Copy link
Contributor

@joaohf joaohf commented Mar 6, 2022

Hello,

This PR intend to fix cross compilation issues for wx. And uses the same strategy following #5728.

Without this patch I got:

builder@f985825fa055:/build/tmp/work/cortexa57-poky-linux/erlang/25.0-rc1-r0/git$ find -name config.log
./erts/config.log
./lib/crypto/config.log
./lib/common_test/config.log
./lib/wx/config.log
./lib/snmp/config.log
./lib/megaco/config.log
./lib/erl_interface/config.log
./make/config.log
builder@f985825fa055:/build/tmp/work/cortexa57-poky-linux/erlang/25.0-rc1-r0/git$ grep  'unsafe for cross-compilation' ./lib/wx/config.log
cc1: warning: include location "/usr/local/include" is unsafe for cross-compilation [-Wpoison-system-directories]

The general OpenGL detection is right, the issue is when the configure tries to find it in the alternative folders like /usr/X11R6 and usr/local/.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2022

CT Test Results

  1 files  11 suites   1m 43s ⏱️
80 tests 76 ✔️ 4 💤 0
84 runs  80 ✔️ 4 💤 0

Results for commit 547d87a.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@rickard-green rickard-green added the team:PS Assigned to OTP team PS label Mar 7, 2022
@IngelaAndin IngelaAndin added the team:VM Assigned to OTP team VM label Apr 22, 2022
@IngelaAndin
Copy link
Contributor

Same as #5770

@IngelaAndin IngelaAndin added the stalled waiting for input by the Erlang/OTP team label Apr 25, 2022
@IngelaAndin IngelaAndin added the review_help_wanted Help with review wanted label Oct 24, 2023
@IngelaAndin IngelaAndin removed the team:PS Assigned to OTP team PS label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low review_help_wanted Help with review wanted stalled waiting for input by the Erlang/OTP team team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants