Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for situationally broken apropos command #1711 #1712

Merged
merged 4 commits into from
Mar 11, 2025

Conversation

zaughon
Copy link
Contributor

@zaughon zaughon commented Feb 24, 2025

Added fix situationally broken apropos command when self.bot_config.HIDE_RESTRICTED_COMMANDS was used.
#1711

Additionally removed unused get_name function

Copy link
Contributor

@nzlosh nzlosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nzlosh
Copy link
Contributor

nzlosh commented Feb 26, 2025

You should also update the changelog.

@zaughon
Copy link
Contributor Author

zaughon commented Feb 27, 2025

I hope that was the changelog you wanted updated? :)

@zaughon zaughon requested a review from nzlosh March 3, 2025 13:38
@nzlosh
Copy link
Contributor

nzlosh commented Mar 3, 2025

@sijis will need to review and merge. I don't have merge permission

@sijis sijis merged commit 9fda9b8 into errbotio:master Mar 11, 2025
5 checks passed
@sijis
Copy link
Contributor

sijis commented Mar 11, 2025

@zaughon thank you!

@zaughon
Copy link
Contributor Author

zaughon commented Mar 13, 2025

Np, and thank you both as well! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants