Fix missing stream tag for connection-timeout errors #4559

tomaszwojcikowski · 2025-09-10T13:47:17Z

Changes:

Fixed stream error format: Added proper <stream:stream> opening tag before sending connection-timeout errors during the wait_for_stream state
Added comprehensive test: Created disconnect_inactive_tcp_connection_after_timeout test case to verify that inactive TCP connections receive proper XMPP stream error format and are closed after the configured state_timeout

Problem: Previously, when a client connected via TCP but didn't send any XMPP data within the state_timeout period, the server would send a malformed error response missing the required stream opening tag.

Solution: Handle the state_timeout event specifically during the wait_for_stream state to ensure proper XMPP stream error formatting with the correct <stream:stream> wrapper.

codecov · 2025-09-10T13:58:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.46%. Comparing base (5d97d91) to head (a533781).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4559      +/-   ##
==========================================
- Coverage   85.91%   85.46%   -0.45%     
==========================================
  Files         565      565              
  Lines       33855    33857       +2     
==========================================
- Hits        29085    28935     -150     
- Misses       4770     4922     +152

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

chrzaszcz

I added a few comments.

big_tests/tests/connect_SUITE.erl

src/c2s/mongoose_c2s.erl

chrzaszcz

Looks good in general. I added minor comments.

big_tests/tests/connect_SUITE.erl

mongoose-im · 2025-09-12T13:41:58Z

elasticsearch_and_cassandra_28 / elasticsearch_and_cassandra_mnesia / a533781
Reports root/ big
OK: 683 / Failed: 0 / User-skipped: 72 / Auto-skipped: 0

small_tests_28 / small_tests / a533781
Reports root / small

small_tests_27 / small_tests / a533781
Reports root / small

small_tests_28_arm64 / small_tests / a533781
Reports root / small

ldap_mnesia_28 / ldap_mnesia / a533781
Reports root/ big
OK: 2339 / Failed: 0 / User-skipped: 1352 / Auto-skipped: 0

dynamic_domains_mysql_redis_28 / mysql_redis / a533781
Reports root/ big
OK: 5170 / Failed: 0 / User-skipped: 154 / Auto-skipped: 0

ldap_mnesia_27 / ldap_mnesia / a533781
Reports root/ big
OK: 2339 / Failed: 0 / User-skipped: 1352 / Auto-skipped: 0

internal_mnesia_28 / internal_mnesia / a533781
Reports root/ big
OK: 2472 / Failed: 1 / User-skipped: 1218 / Auto-skipped: 0

pubsub_SUITE:dag+basic:subscribe_options_deliver_option_test

{error,
  {timeout_when_waiting_for_stanza,
    [{escalus_client,wait_for_stanza,
       [{client,
          <<"geralt_subscribe_options_deliver_option_test_1752@localhost/res1">>,
          escalus_ws,<0.53287.0>,
          [{event_manager,<0.53156.0>},
           {server,<<"localhost">>},
           {username,
             <<"geralt_subscribe_options_deliver_option_test_1752">>},
           {resource,<<"res1">>}],
          [{event_client,
             [{event_manager,<0.53156.0>},
            {server,<<"localhost">>},
            {username,
              <<"geralt_subscribe_options_deliver_option_test_1752">>},
            {resource,<<"res1">>}]},
           {resource,<<"res1">>},
           {username,
             <<"geralt_subscribe_options_deliver_option_test_1752">>},
           {server,<<"localhost">>},
           {host,<<"localhost">>},
           {port,5280},
           {auth,fun escalus_auth:auth_plain/2},
           {wspath,<<"/ws-xmpp">>},
           {username,
             <<"geralt_subscribe_options_deliver_option_test_1752">>},
           {server,<<"localhost">>},
           {password,<<"witcher">>},
           {transport,escalus_ws},
           {port,5280},
           {wspath,<<"/ws-xmpp">>},
           {stream_id,<<"ee28e6a317db1049">>}]},
        5000],
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_client.erl"},
        {line,136}]},
     {pubsub_tools,receive_notification,3,
       [{file,"/home/circleci/...

Fix missing stream tag for connection-timeout errors #4559

Fix missing stream tag for connection-timeout errors #4559

Uh oh!

Conversation

tomaszwojcikowski commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

codecov bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

chrzaszcz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

chrzaszcz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mongoose-im commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrzaszcz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tomaszwojcikowski commented Sep 10, 2025 •

edited

Loading

codecov bot commented Sep 10, 2025 •

edited

Loading

mongoose-im commented Sep 12, 2025 •

edited

Loading