Closed
Conversation
…ript file, usage in esm-master
…e to also have subclasses for SLURMBatchScriptTemplate and PBSBatchScriptTemplate
Contributor
|
Can this be closed @pgierz? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1300, but for esm-environment. This time we set up jinja2 templates for the environment batch files, which makes a lot of the code collapse.
Still very much WIP, so far works for
The big missing part here is setting up the configuration dictionary to already have compiletime or runtime settings. I feel that this should be done outside from the actual environment generator to cleanly separate the responsibilities, but functions to prepare that could go into esm-environment.