Modify Config during Error Checking

[pgierz]

This allows the error checker to modify config values. It adds a new dependency dpath to the project.

Untested, but should work...

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

If only one of 'set_config_key' or 'set_config_value' is provided, the config update is silently skipped. Consider adding logging or a warning to help debug misconfigurations.

[pgierz]

Logging would be helpful, that is a good suggestion...

[Copilot]

The version specifier '>=2.0.7' contradicts the comment stating a maximum version is required for Python 3.6 support. Consider revising the version constraint (e.g., using '<=' if a maximum version is intended).

Suggested change

	"dpath>=2.0.7", # Maximum version for Python 3.6 support
	"dpath>=2.0.7, <2.1.0", # Maximum version for Python 3.6 support

[pgierz]

This is a bad suggestion, or maybe an indication of bad working in my comment: we need 2.0.7 or newer (2.0.7 is the highest version still supports Python 3.6)

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/esm_runscripts/observe.py:144

• Using a bare except can mask unexpected errors. Consider catching a specific exception to improve error handling clarity.

except:

[Copilot]

The variables 'set_config_key' and 'set_config_value' are defined conditionally. To ensure they are always available later in the function, consider initializing them to None before the conditional block.

[pgierz]

This is done below, so the comment is not needed.