Skip to content

Fesom 2.7.0 standalone#1399

Open
JanStreffing wants to merge 4 commits intoreleasefrom
feat/fesom2.7.0
Open

Fesom 2.7.0 standalone#1399
JanStreffing wants to merge 4 commits intoreleasefrom
feat/fesom2.7.0

Conversation

@JanStreffing
Copy link
Contributor

No description provided.

@JanStreffing JanStreffing self-assigned this Nov 17, 2025
@JanStreffing JanStreffing added the enhancement New feature or request label Nov 17, 2025
@mandresm
Copy link
Contributor

Looks good to me but for some reason, CI tests are failing. I'm looking into that. Also including fesom2.7 into the esm_tests

@mandresm
Copy link
Contributor

FESOM is failing to compile in the first test I ran. See /work/ab0246/a270152/testing/comp/fesom/fesom-2.7/comp.out

@JanStreffing
Copy link
Contributor Author

I thought it was a good idea to turn OMP on by default. Seems thats not the case.

Two solutions:
a) turn omp off in the fesom 2.7 in the comp_command.
b) make a change in the cmakelist.txt in fesom to prevent this error:

if(${ENABLE_OPENMP})
   target_link_libraries(${PROJECT_NAME}.x PRIVATE OpenMP::OpenMP_Fortran)
endif()

I suggest we do both. a) for a quick fix now, b) for 2.7.1.

@mandresm
Copy link
Contributor

The errors during compilation still persist after having set -DOPENMP=OFF. See agian /work/ab0246/a270152/testing/comp/fesom/fesom-2.7/comp.out

@JanStreffing
Copy link
Contributor Author

Sorry for the long wait. Can you do the test again? It seems to have been cleaned up.

@mandresm
Copy link
Contributor

mandresm commented Jan 15, 2026

Sorry for the delay @JanStreffing, I have reproduced the error again when I turned -DOPENMP=OFF. The log file is in the same path as before: /work/ab0246/a270152/testing/comp/fesom/fesom-2.7/comp.out

@JanStreffing
Copy link
Contributor Author

does the same error happen when you copy the comp script from
/work/ab0246/a270092/model_codes/comp-fesom-2.7_script.sh
?

@pgierz
Copy link
Member

pgierz commented Mar 10, 2026

I made a small correction to the comp command (stray comma) and found two mesh directories that were pointing to ollie (@patrickscholz's folder) and one in the home of @christian-stepanek. I've made a small note about both, those should migrate to a shared pool eventually.

I can have a look at running esm-tests for this later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants