add hostfiles to the tracked files in last_tested for esm_tests#1449
Open
add hostfiles to the tracked files in last_tested for esm_tests#1449
Conversation
(cherry picked from commit 29e7a69)
(cherry picked from commit 1dd65d8)
pgierz
approved these changes
Mar 9, 2026
Member
pgierz
left a comment
pgierz
left a comment
There was a problem hiding this comment.
Looks good, approve. Some things worth noting for the future:
-
Duplicate
compare_filesin output.py and tests.py makes sense for how it is structured, but we should at some point go for a single point of truth -
Ideally I'd like to use pathlib, but that would be a full refactor inside of esm-tests. Out of scope for this PR, we can catch up on that later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add hostfiles to the tracked files in last_tested for esm_tests. I need this for the
geomarmerge, and in general it would be nice to track also hostfiles.