Skip to content

fix: Windows icon for windows build #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged

fix: Windows icon for windows build #5

merged 2 commits into from
Mar 18, 2025

Conversation

finger563
Copy link

@finger563 finger563 commented Mar 18, 2025

Description

Update icon and path to ensure package works on windows.

Motivation and Context

We'd like the packaging to build for all platforms.

How has this been tested?

Testing all the packaged executables built in CI for this PR.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 changed the title try to fix windows icon fix: Windows icon for windows build Mar 18, 2025
@finger563 finger563 added bug Something isn't working packaging windows labels Mar 18, 2025
@finger563 finger563 merged commit 5dfb965 into main Mar 18, 2025
3 checks passed
@finger563 finger563 deleted the fix/windows-icon branch March 18, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packaging windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant