nvs: support StorageIterate #249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
See this though. Let me know what you think. |
This implements `StorageIterate` for `EspNvs`. Note that while the `Error` on iteration is setup to work, the actual implementation in esp-idf does not return any errors during iteration (other than "Not Found", indicating iteration is complete). As a result, `next()` will always return `Some(Ok(...))` or `None` and never `Some(Err(...))`.
ivmarkov
force-pushed
the
master
branch
3 times, most recently
from
8a8adba to
5ccb542
Compare
Collaborator
|
Closing as #599 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
StorageIterateforEspNvs. Note that while theErroron iteration is setup to work, the actual implementation in esp-idf does not return any errors during iteration (other than "Not Found", indicating iteration is complete). As a result,next()will always returnSome(Ok(...))orNoneand neverSome(Err(...)).This depends on the esp-idf 5 iteration APIs (the ones in esp-idf 4 aren't supported) plus the change in espressif/esp-idf#11118. (Which we can apply in esp-idf-sys).
Plan on landing this:
embedded-svc PR: esp-rs/embedded-svc#48