Check app_desc _only_ for esp-hal projects
#892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
reviewed
Jun 18, 2025
| if !section || !symbol { | ||
| // esp-hal specific, because it searches for the hard-coded esp_app_desc symbol | ||
| // in an ELF section | ||
| if esp_hal && (!section || !symbol) { | ||
| return Err(Error::AppDescriptorNotPresent).into_diagnostic(); |
There was a problem hiding this comment.
I think this bit still needs some more work, based on my comment here: #886 (comment)
We should still return an error if the section is missing from either type of binary, but we should only tell users to use esp-bootloader-idf if we detect that it's an esp-hal binary. I'm hoping we can customize the error context with thiserror or miette for this purpose 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: For testing non-esp-hal based project, I used ESP-IDF's hello_world example, and I hope it is valid test.
closes #886