Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken links in Xiaomi-Mijia-Bedside-Lamp-2/index.md #982

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

sfromis
Copy link
Contributor

@sfromis sfromis commented Jan 10, 2025

The linked repository https://github.com/mmakaay/esphome-xiaomi_bslamp2 no longer has a "main" branch; links changed to refer to the "dev" branch", preferring this over one of the "release/" branches. OK?

Brief description of the changes

Type of changes

  • New device
  • Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

  • There are no passwords or secrets references in any examples.
    The only exceptions are !secret wifi_ssid and !secret wifi_password.
  • The wifi or ethernet block has no static / manual ip address specified.
  • The first configuration provided should be hardware definitions only.
    A more involved example can be provided in a separate configuration block.

The linked repository https://github.com/mmakaay/esphome-xiaomi_bslamp2 no longer has a "main" branch; links changed to refer to the "dev" branch", preferring this over one of the "release/" branches. OK?
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit 8f774ce
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/67819001e99aaa000837b77d
😎 Deploy Preview https://deploy-preview-982--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tekmaven tekmaven merged commit 72fadde into esphome:main Jan 11, 2025
6 checks passed
@sfromis sfromis deleted the patch-1 branch January 11, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants