-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Restore link on logo in searchbar #4806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the HTML structure in Changes
Suggested labels
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
_templates/searchbox.html (1)
1-29
: Restore of the Logo Link StructureThe new structure correctly wraps the SVG logo within an anchor tag linking to
/components/index.html
and encloses the entire element within a<p class="logo">
container. This change effectively restores the clickable logo functionality as intended by PR #4806.Consider evaluating whether a
<div>
might be a more semantically appropriate container than a<p>
for the logo element, especially if it solely contains non-paragraph content.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
_templates/searchbox.html
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**`: - Do not generate or add any sequence diagrams
**
: - Do not generate or add any sequence diagrams
_templates/searchbox.html
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
See #4789? |
I hadn't - it's addressing the same issue though. It links back to /, I picked the component page, which is the actual docs. Not bothered either way, but my PR restores the HTML to how it looked with when Sphinx was providing the logo, reusing the existing CSS. |
Description:
PR #4736 broke the link on the logo in the searchbar.
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rst
when creating new documents for new components or cookbook.