-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(board): Alfredo NoU3 pins_arduino.h uses uint8_t but it causes error with esp32-hal-gpio.h #11206
base: master
Are you sure you want to change the base?
Conversation
👋 Hello SaintSampo, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this change is necessary.
@SaintSampo - Please provide an example of why this is a fix for an issue. What issue is it?
Hi @SuGlider, thank you for taking a look at this issue for us. I found that I could not compile for an Alfredo NoU3 board with esp32 v3.2.0. While Arduino.h includes Here's an example that failed to compile. https://github.com/AlfredoSystems/Alfredo-NoU3/tree/main/examples/MotorParty I have attached the output from the Arduino IDE showing that with esp32 version 3.2.0 the example only compiles when I edited failed compile log with esp32 version 3.2.0.txt Is there any harm in including Thank you, espressif community, for your time. |
@joshua-8 - Thanks for the explanation and log files. The way to fix it for this board and all other possible boards that may use I'll push the commits necessary to this PR. Thanks. |
@joshua-8 - Please test this PR with the target board and sketches. It shall be solved now. |
@SaintSampo @joshua-8 - My bad.... actually all other |
Test Results 76 files 76 suites 12m 40s ⏱️ Results for commit df47d76. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Description of Change
Starting in core version 3.2.0, this pins_arduino.h file fails to compile without stdint.h
Tests scenarios
Tested with 3.1.3 and 3.2.0. File compiles in the former but not the latter (uint8_t not defined). I'm curious what caused this change but just hoping this fixes in. I would be surprised if other pins files don't have this issue.