-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CONFIG_BT_BLUEDROID_ENABLED for enabling #11214
base: master
Are you sure you want to change the base?
Conversation
👋 Hello Jason2866, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 12m 42s ⏱️ Results for commit 9d3911c. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Bluetooth configuration check to use CONFIG_BT_BLUEDROID_ENABLED instead of the generic CONFIG_BT_ENABLED to ensure compatibility with Arduino compiled as an IDF component.
- Update the preprocessor directive to check for Bluedroid support
- Prevent build failures when NimBLE is enabled in IDF
since compiling Arduino as an component of IDF will fail when BT NimBLE is used and enabled in IDF instead of Bluedroid.
@me-no-dev