esp_memory_resource a PMR memory resource #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
0xjakob
reviewed
Aug 2, 2023
| esp_log_level_set("*", ESP_LOG_INFO); | ||
| esp_log_level_set(idf::memory::resource::tag, ESP_LOG_VERBOSE); | ||
| using enum idf::memory::capabilities; | ||
| auto memory_source = dma; |
There was a problem hiding this comment.
nitpick: either not using auto or the using declaration might make the type clearer when reading the code. But changing it is not a must.
| return capabilities{std::to_underlying(lhs) | std::to_underlying(rhs)}; | ||
| } | ||
|
|
||
| class resource : public std::pmr::memory_resource { |
There was a problem hiding this comment.
For my taste, a simple comment what this class does and guiding users to the documentation of PMR would be helpful.
euripedesrocha
force-pushed
the
memory_resource
branch
from
0da906f to
a11c23e
Compare
euripedesrocha
force-pushed
the
memory_resource
branch
4 times, most recently
from
66c4c4d to
18b5623
Compare
Simple memory resource class enabling the usage of C++17 PMR facilities with IDF heap allocation capabilities.
euripedesrocha
force-pushed
the
memory_resource
branch
from
18b5623 to
fb0b712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple memory resource class enabling the usage of C++17 PMR facilities with IDF heap allocation capabilities.
This enables users to set the heap memory destination for C++ containers.