Skip to content

fix: removed failing ESP Event unit test #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: removed failing ESP Event unit test #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions test_apps/esp_event/main/test_esp_event.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,25 +530,26 @@ TEST(esp_event, ESPEventLoop_direct_register_timeout_and_event_no_timeout)
TEST_ASSERT_EQUAL(false, fix.timeout);
}

/**
* Registers an event via both set_timeout() and register_event().
* Result: both handlers will be invoked, the timeout callback won't be called.
*/
TEST(esp_event, ESPEventLoop_register_timeout_and_event_timeout)
{
EventLoopFix fix;

ESPEventReg reg(fix.handler0, TEMPLATE_EVENT_0, fix.api);
ESPEventRegTimed timed_reg(fix.handler1, TEMPLATE_EVENT_0, fix.timer_cb, MIN_TIMEOUT, fix.api);

vTaskDelay(10 / portTICK_PERIOD_MS);
send_default_event();

TEST_ASSERT(fix.ev0 == TEMPLATE_EVENT_0);
TEST_ASSERT_EQUAL(false, fix.ev1_called);
TEST_ASSERT(fix.timeout_event == TEMPLATE_EVENT_0);
TEST_ASSERT_EQUAL(true, fix.timeout);
}
// TODO: temporarily removed this case since it's failing randomly in CI (IDF-6929)
///**
// * Registers an event via both set_timeout() and register_event().
// * Result: both handlers will be invoked, the timeout callback won't be called.
// */
//TEST(esp_event, ESPEventLoop_register_timeout_and_event_timeout)
//{
// EventLoopFix fix;
//
// ESPEventReg reg(fix.handler0, TEMPLATE_EVENT_0, fix.api);
// ESPEventRegTimed timed_reg(fix.handler1, TEMPLATE_EVENT_0, fix.timer_cb, MIN_TIMEOUT, fix.api);
//
// vTaskDelay(10 / portTICK_PERIOD_MS);
// send_default_event();
//
// TEST_ASSERT(fix.ev0 == TEMPLATE_EVENT_0);
// TEST_ASSERT_EQUAL(false, fix.ev1_called);
// TEST_ASSERT(fix.timeout_event == TEMPLATE_EVENT_0);
// TEST_ASSERT_EQUAL(true, fix.timeout);
//}

TEST(esp_event, ESPEventLoop_custom_loop_register_receive_unregister_ESPEvent)
{
Expand Down Expand Up @@ -654,7 +655,7 @@ TEST_GROUP_RUNNER(esp_event)
RUN_TEST_CASE(esp_event, ESPEventLoop_no_timeout)
RUN_TEST_CASE(esp_event, ESPEventLoop_register_timeout_and_event_no_timeout)
RUN_TEST_CASE(esp_event, ESPEventLoop_direct_register_timeout_and_event_no_timeout)
RUN_TEST_CASE(esp_event, ESPEventLoop_register_timeout_and_event_timeout)
// RUN_TEST_CASE(esp_event, ESPEventLoop_register_timeout_and_event_timeout)
RUN_TEST_CASE(esp_event, ESPEventLoop_custom_loop_register_receive_unregister_ESPEvent)
RUN_TEST_CASE(esp_event, ESPEventAPIDefault_initialization_failure)
RUN_TEST_CASE(esp_event, ESPEventAPICustom_no_mem)
Expand Down