[modem]: Use pre-generated command declarations to improve IDE navigation #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clang-tidy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
david-cermak
force-pushed
the
fix/modem_generate_code
branch
10 times, most recently
from
09506d0 to
3d328f7
Compare
david-cermak
changed the title
david-cermak
changed the title
david-cermak
requested review from
euripedesrocha,
alisitsyn,
kostaond,
espressif-abhikroy and
bogdankolendovskyy
|
|
@diplfranzhoepfinger PTAL, too. |
Yes. IDE Navigation in Espressif IDE is a nightmare in esp-modem. Thanks |
euripedesrocha
approved these changes
Dec 11, 2024
david-cermak
force-pushed
the
fix/modem_generate_code
branch
2 times, most recently
from
7783e4d to
3f93f03
Compare
david-cermak
force-pushed
the
fix/modem_generate_code
branch
2 times, most recently
from
9800677 to
1c47981
Compare
BREAKING CHANGE: inc headers for AT command definitions are no longer used directly, but pregenerated into *.h(pp)
david-cermak
force-pushed
the
fix/modem_generate_code
branch
from
1c47981 to
e2fa111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use generated AT command definitions for IDE navigation
Task list
**/generate/*.incand to the documentation(split the commands into groups -- maybe in a separate PR)
How to review this PR
*.incfiles -- primary sources of AT command APIs and helper macros**/generate/*.(hpp|cpp)-- generic (templates) of using the AT command prototypes and implemenations**/command/*.(hpp|cpp)-- generated output, used in "component user" mode