-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mdns): supported removal of subtype when updating service (IDFGH-14413) #731
Merged
david-cermak
merged 1 commit into
espressif:master
from
tanyanquan:feat/update_subtype_removal
Jan 20, 2025
Merged
feat(mdns): supported removal of subtype when updating service (IDFGH-14413) #731
david-cermak
merged 1 commit into
espressif:master
from
tanyanquan:feat/update_subtype_removal
Jan 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwx1995esp
reviewed
Jan 13, 2025
f31db06
to
541cef1
Compare
9ec80e1
to
ed86bb3
Compare
zwx1995esp
reviewed
Jan 15, 2025
a6ae193
to
40ba06b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nitpicks and questions
40ba06b
to
4ad88e2
Compare
david-cermak
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR supports the updating of mdns services when subtypes are changing.
For example, if we start with a client which provides services _sub1,_sub2,_sub3,_sub4, and the client updates itself to now provide services _sub1,_sub5:
In the old implementation, the server only sends out a single new mdns packet with:
However, it is also important to send out a goodbye packet for:
This is similar to the behavior when entire services are removed, to ensure that subtypes are promptly updated as well.
Other tested scenarios include:
heapdiag print
has also been used to check for memory leaks, after performing multiple iterations of the above scenarios.Moreover, any scheduled subtype answers will also be removed from their service to ensure that subsequent tx do not include false information about subtypes which have already been removed.