Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmux log message fix (IDFGH-14853) #782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

term-est
Copy link
Contributor

I want you to know that it took a lot of effort and self restraint to be mature about this pull request. The 12 year old in me is tempting me to change the pull request title to some stupid joke >_<

Special thanks for making my warning logs look so lewd
image

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title cmux log message fix cmux log message fix (IDFGH-14853) Mar 14, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Mar 14, 2025
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

Could you please install the pre-commit hook and fix these cosmetic issues:

  • message commit -> fix(modem): Fix cmux log message
  • astyle formatting of the cmux module (you add and commit changes suggested by the hook)

@david-cermak
Copy link
Collaborator

Note that these warnings indicate that the cmux works sub optimal and you should use bigger buffer (or disable defragmenting)

// If you experience this error, your device uses longer payloads while
// the configured buffer is too small to defragment the payload properly.
// To resolve this issue you can:
// * Either increase `dte_buffer_size`
// * Or disable `ESP_MODEM_CMUX_DEFRAGMENT_PAYLOAD` in menuconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants