refactor(uac_host): Suspend/Resume public API terminology#363
refactor(uac_host): Suspend/Resume public API terminology#363peter-marcisovsky wants to merge 1 commit intomasterfrom
Conversation
eb0dc1f to
e2049a8
Compare
e2049a8 to
26e3caf
Compare
|
@tore-espressif Here is a regression from conditional CI run. In this PR, there are only UAC changes. Its test app does not have any pytest file with target runner marker, so there is no target test to be run in this PR. Yet still the CI fails. I tried to replicate it locally and it is behaving the same way.
|
@peter-marcisovsky I'm sorry about that, it was working before I merged it... I'll have a look ASAP |
- Replaced suspend/resume with pause/unpuase terminology
- Preparation for suspend/resume support
26e3caf to
1d49837
Compare
igi540
left a comment
There was a problem hiding this comment.
Reserving “suspend/resume” for the upcoming real root-port/device suspend/resume support makes sense.
One question about API compatibility and future semantics:
Since this is a public API rename (uac_host_device_suspend()/resume() + FLAG_STREAM_SUSPEND_AFTER_START), existing user code will stop compiling after this change. Would it make sense to keep the old names as deprecated aliases (wrappers/macros mapping to pause/unpause) for at least one release, and document the migration in the changelog/README?
This might also help avoid a more subtle issue later: once “real suspend/resume” is merged and these names get reused with different behavior, users relying on the current stream-control semantics could get surprised. A deprecation window now would make that transition clearer and safer.
(If you prefer a hard break immediately, could we at least call it out explicitly as a breaking change in the changelog with a short old→new mapping?)
|
After a discussion, it was agreed on, that this change would be considered as a breaking change (with very little actual beneficial change to the users) we have decided to postpone merging this and #211 PR. Considering, there is a planned support of UAC 2.0, we will align this change (delivering suspend/resume feature for the driver) with the UAC 2.0 release plan and will deliver the suspend/resume feature together with the actual UAC 2.0 driver. |
Changes
Why do we need this change
And private API functions
The API shall be changed in a following way, not to confuse the users with the public API terminology
Related
Checklist
Before submitting a Pull Request, please ensure the following:
Note
Standardizes UAC stream control terminology from suspend/resume to pause/unpause.
uac_host_device_suspend/resume->uac_host_device_pause/unpause;FLAG_STREAM_SUSPEND_AFTER_START->FLAG_STREAM_PAUSE_AFTER_STARTuac_host_interface_suspend/resume->..._pause/unpause,SUSPENDING->PAUSING); comments/logs updatedFLAG_STREAM_PAUSE_AFTER_STARTbehaviorWritten by Cursor Bugbot for commit 1d49837. This will update automatically on new commits. Configure here.