Skip to content

Commit 7e08a0a

Browse files
authored
Merge pull request #770 from RubenKelevra/bugfix/hm1055_set_brightness_return_handling
hm1055: fix set_brightness error handling & logging
2 parents f0814e6 + 7ffdae8 commit 7e08a0a

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

sensors/hm1055.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -449,8 +449,11 @@ static int set_brightness(sensor_t *sensor, int level)
449449

450450
ispctrl5 |= 0x40; // enable brightness
451451
ret = write_reg(sensor->slv_addr, ISPCTRL5, ispctrl5);
452-
ret = write_reg(sensor->slv_addr, BRIGHT, brightness);
453-
if (ret != 0)
452+
if (ret == 0)
453+
{
454+
ret = write_reg(sensor->slv_addr, BRIGHT, brightness);
455+
}
456+
if (ret == 0)
454457
{
455458
ESP_LOGD(TAG, "Set brightness to: %d", level);
456459
sensor->status.brightness = level;

0 commit comments

Comments
 (0)