Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #159
Fix #150
Fix #151
Fix #38
Fix #135
Fix #141
Fix #86
Fix #87
Description
Re-write the transport read and slip parsing to match esptool.py. This method should remove the timeout issue seen in most reported issue.
Update stubs to match current esptool.py stubs. Change baud issue in #159 was probably due to stub entry not matching.
Testing
You can test on my fork in https://brianignacio5.github.io/esptool-js/
Or test by
npm run dev
the examples/typescript afternpm run build
in root directory. This will generate a localhost version of https://espressif.github.io/esptool-js/ to test.You can compare the trace output of esptool.py with esptool-js (there is a copy trace button that will copy the trace in clipboard or just review the Developer Tools console output).
Checklist
Before submitting a Pull Request, please ensure the following: