Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update serial slip read #160

Merged
merged 5 commits into from
Nov 28, 2024
Merged

update serial slip read #160

merged 5 commits into from
Nov 28, 2024

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Nov 12, 2024

Fix #159
Fix #150
Fix #151
Fix #38
Fix #135
Fix #141
Fix #86
Fix #87

Description

Re-write the transport read and slip parsing to match esptool.py. This method should remove the timeout issue seen in most reported issue.

Update stubs to match current esptool.py stubs. Change baud issue in #159 was probably due to stub entry not matching.

Testing

You can test on my fork in https://brianignacio5.github.io/esptool-js/

Or test by npm run dev the examples/typescript after npm run build in root directory. This will generate a localhost version of https://espressif.github.io/esptool-js/ to test.

You can compare the trace output of esptool.py with esptool-js (there is a copy trace button that will copy the trace in clipboard or just review the Developer Tools console output).


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@brianignacio5 brianignacio5 added the enhancement New feature or request label Nov 12, 2024
@brianignacio5 brianignacio5 self-assigned this Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 merged commit 3a01130 into main Nov 28, 2024
1 check passed
@brianignacio5 brianignacio5 deleted the bugfix/webserial-slip-read branch November 28, 2024 07:27
@tyeth
Copy link

tyeth commented Dec 4, 2024

@brianignacio5 any chance you can do a release please so unpkg bundle.js gets updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment