-
Notifications
You must be signed in to change notification settings - Fork 125
Building for ESP32-P4 using esp_hosted and esp_wifi_remote (IEC-388) #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mantriyogesh
wants to merge
1
commit into
espressif:master
Choose a base branch
from
mantriyogesh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,11 @@ dependencies: | |
| espressif/network_provisioning: | ||
| version: "*" | ||
| override_path: '../../../' | ||
|
|
||
| espressif/esp_wifi_remote: | ||
| version: ">=0.10" | ||
| rules: | ||
| - if: "target in [esp32p4, esp32h2]" | ||
| espressif/esp_hosted: | ||
| version: "~2" | ||
| rules: | ||
| - if: "target in [esp32p4, esp32h2]" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as earlier to remove H2 |
||
36 changes: 36 additions & 0 deletions
36
network_provisioning/examples/wifi_prov/sdkconfig.defaults.esp32p4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # Override some defaults so BT stack is enabled | ||
| # in this example | ||
|
|
||
| CONFIG_FREERTOS_HZ=1000 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably we can remove this - not a mandatory requirement? |
||
|
|
||
| # BT config | ||
| CONFIG_BT_ENABLED=y | ||
| CONFIG_BT_CONTROLLER_DISABLED=y | ||
| CONFIG_BT_BLUEDROID_ENABLED=n | ||
| CONFIG_BT_NIMBLE_ENABLED=y | ||
| CONFIG_BT_NIMBLE_TRANSPORT_UART=n | ||
|
|
||
| # Wi-Fi Remote | ||
| CONFIG_ESP_WIFI_REMOTE_LIBRARY_HOSTED=y | ||
|
|
||
| # Enable ESP Hosted BT | ||
| ## Use Hosted-HCI (https://github.com/espressif/esp-hosted-mcu/blob/main/docs/bluetooth_design.md#3-bluetooth-interface) | ||
| CONFIG_ESP_HOSTED_ENABLE_BT_NIMBLE=y | ||
| CONFIG_ESP_HOSTED_NIMBLE_HCI_VHCI=y | ||
|
|
||
| # Wi-Fi performance config | ||
| CONFIG_WIFI_RMT_STATIC_RX_BUFFER_NUM=16 | ||
| CONFIG_WIFI_RMT_DYNAMIC_RX_BUFFER_NUM=64 | ||
| CONFIG_WIFI_RMT_DYNAMIC_TX_BUFFER_NUM=64 | ||
| CONFIG_WIFI_RMT_AMPDU_TX_ENABLED=y | ||
| CONFIG_WIFI_RMT_TX_BA_WIN=32 | ||
| CONFIG_WIFI_RMT_AMPDU_RX_ENABLED=y | ||
| CONFIG_WIFI_RMT_RX_BA_WIN=32 | ||
|
|
||
| # LWIP performance config | ||
| CONFIG_LWIP_TCP_SND_BUF_DEFAULT=65534 | ||
| CONFIG_LWIP_TCP_WND_DEFAULT=65534 | ||
| CONFIG_LWIP_TCP_RECVMBOX_SIZE=64 | ||
| CONFIG_LWIP_UDP_RECVMBOX_SIZE=64 | ||
| CONFIG_LWIP_TCPIP_RECVMBOX_SIZE=64 | ||
| CONFIG_LWIP_TCP_SACK_OUT=y | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we remove from H2 from the list? H2 can support thread provisioning in standalone manner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that H2 can be removed, as H2 is not mentioned in the supported targets list of README file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually H2 can use wifi-remote & hosted for wifi provisioning. So should we keep it or not, @mahavirj ?
I will update H2 in supported target accordingly..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mantriyogesh For H2, we recommend using
network_provisioning/examples/thread_provexample. H2 is already listed a supported target here.Is this for Thread Boarder router use-case? Does it use hosted approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree the H Series would be native wifi provisioning generally be used and is more intuitive.
But if H2 wants to do wifi based provisioning (technically be possible using two chip using esp-wifi-remote & esp-hosted duo).