Skip to content

feat: adds PSA DS driver support#661

Open
Ashish285 wants to merge 1 commit intomasterfrom
feat/esp_enc_img_psa_support
Open

feat: adds PSA DS driver support#661
Ashish285 wants to merge 1 commit intomasterfrom
feat/esp_enc_img_psa_support

Conversation

@Ashish285
Copy link
Collaborator

@Ashish285 Ashish285 commented Jan 13, 2026

Checklist

  • Component contains License
  • Component contains README.md
  • Component contains idf_component.yml file with url field defined
  • Component was added to upload job
  • Component was added to build job
  • Optional: Component contains unit tests
  • CI passing

Change description

Please describe your change here

@Ashish285 Ashish285 requested a review from Copilot January 13, 2026 01:30
Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link

github-actions bot commented Jan 13, 2026 •
edited
Loading

Test Results

40 files  40 suites   3m 31s ⏱️
 6 tests  0 ✅  6 💤 0 ❌
13 runs   0 ✅ 13 💤 0 ❌

Results for commit 280722a.

♻️ This comment has been updated with latest results.

@Ashish285 Ashish285 force-pushed the feat/esp_enc_img_psa_support branch from 8b9ddc9 to b4cc0e8 Compare January 13, 2026 03:15
@Ashish285 Ashish285 requested a review from Copilot January 13, 2026 03:15
Copilot AI reviewed Jan 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Ashish285 Ashish285 force-pushed the feat/esp_enc_img_psa_support branch from b4cc0e8 to 2917ea5 Compare January 14, 2026 07:25
@Ashish285 Ashish285 requested a review from Copilot January 14, 2026 07:25
Copilot AI reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Ashish285 Ashish285 force-pushed the feat/esp_enc_img_psa_support branch 2 times, most recently from c345ad6 to 21a257c Compare January 16, 2026 10:26
@Ashish285 Ashish285 requested a review from Copilot January 16, 2026 10:27
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Ashish285 Ashish285 force-pushed the feat/esp_enc_img_psa_support branch from 21a257c to 5feae56 Compare January 19, 2026 07:08
@Ashish285 Ashish285 requested a review from Copilot January 19, 2026 07:08
Copilot AI reviewed Jan 19, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Ashish285 Ashish285 force-pushed the feat/esp_enc_img_psa_support branch from 5feae56 to 728cb3e Compare January 19, 2026 07:43
@Ashish285 Ashish285 requested a review from Copilot January 19, 2026 07:43
Copilot AI reviewed Jan 19, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Ashish285 Ashish285 force-pushed the feat/esp_enc_img_psa_support branch 2 times, most recently from 0c42813 to 0b3c7b6 Compare January 28, 2026 03:09
@Ashish285 Ashish285 force-pushed the feat/esp_enc_img_psa_support branch 2 times, most recently from fc06e19 to a31721e Compare February 24, 2026 06:42
@Harshal5
Copy link
Collaborator

Harshal5 commented Mar 3, 2026

Hello @Ashish285, could you also include this patch in the your branch:
0001-change-esp_encrypted_img-Use-ESP-RSA-DS-opaque-key-c.patch. It adds a small change needed for using the ESP RSA-DS opaque key context.

@Ashish285 Ashish285 force-pushed the feat/esp_enc_img_psa_support branch from a31721e to 6aaf30b Compare March 4, 2026 02:40
@Ashish285 Ashish285 force-pushed the feat/esp_enc_img_psa_support branch from 6aaf30b to 3009ad1 Compare March 4, 2026 07:02
@Ashish285 Ashish285 requested review from Harshal5 and mahavirj March 4, 2026 07:04
Harshal5
Harshal5 approved these changes Mar 4, 2026
View reviewed changes
Copy link
Collaborator

@Harshal5 Harshal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ashish285 Ashish285 force-pushed the feat/esp_enc_img_psa_support branch from 3009ad1 to 280722a Compare March 6, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mahavirj mahavirj Awaiting requested review from mahavirj

+1 more reviewer

@Harshal5 Harshal5 Harshal5 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ashish285 @Harshal5