Skip to content

Add Python 3.13 support #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Add Python 3.13 support #35

merged 2 commits into from
Nov 6, 2024

Conversation

jakub-kocka
Copy link
Collaborator

@jakub-kocka jakub-kocka commented Oct 8, 2024

Description

  • Updated pre-commit hooks and mypy dependency (all-types is "staged in time" and sub-dependencies has been deleted)
  • Added Python 3.13 support
  • Updated exclude list - some wheels build not working for Python 3.13 (gdbgui, windows-curses)
  • Added Print requirements job for the Python depended wheels for better debugging

Related

Testing

Succeeded job: https://github.com/espressif/idf-python-wheels/actions/runs/11347660297

@jakub-kocka jakub-kocka self-assigned this Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello jakub-kocka, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 15a7457

@jakub-kocka jakub-kocka force-pushed the feat/python3-13_support branch 3 times, most recently from 7527ba8 to 6ad86dd Compare October 10, 2024 07:42
@jakub-kocka jakub-kocka marked this pull request as draft October 10, 2024 07:42
@jakub-kocka jakub-kocka force-pushed the feat/python3-13_support branch 13 times, most recently from e42eaaa to 7e80073 Compare October 16, 2024 07:44
@jakub-kocka jakub-kocka marked this pull request as ready for review October 16, 2024 07:45
@dobairoland
Copy link
Collaborator

@jakub-kocka Thanks, LGTM in general. What do you suggest how should we handle those new cases from the ignore list? We will have to get back to them later. If that period is too long then in the meantime we need restrictions on the ESP-IDF side.

@dobairoland
Copy link
Collaborator

You can use cs01/gdbgui#494 in your comments as tracker.

@jakub-kocka
Copy link
Collaborator Author

@jakub-kocka Thanks, LGTM in general. What do you suggest how should we handle those new cases from the ignore list? We will have to get back to them later. If that period is too long then in the meantime we need restrictions on the ESP-IDF side.

@dobairoland, thanks for the review. I have seen that you have added a message about gdbgui not supported with Python 3.13.

I think we can also update the constraints repository with the cases from the ignore list, this should prevent IDF from demanding a specific version for Python 3.13 if needed.

Can we merge this?

@dobairoland
Copy link
Collaborator

You can use cs01/gdbgui#494 in your comments as tracker.

You haven't linked this issue.

Here is the one for windows_curses: zephyrproject-rtos/windows-curses#69

Maybe this it the one for cryptography: pyca/cryptography#11436

The Windows and the cryptography ARM32 incompatibilities are serious ones and we need to track them internally to get back to this later.

@jakub-kocka jakub-kocka force-pushed the feat/python3-13_support branch 4 times, most recently from 1f933e7 to 793a254 Compare November 4, 2024 11:05
@jakub-kocka jakub-kocka force-pushed the feat/python3-13_support branch from 793a254 to 9907cb4 Compare November 4, 2024 13:01
@jakub-kocka jakub-kocka force-pushed the feat/python3-13_support branch from 9907cb4 to 15a7457 Compare November 4, 2024 14:44
@dobairoland dobairoland merged commit d376e5f into main Nov 6, 2024
1 check passed
@dobairoland dobairoland deleted the feat/python3-13_support branch November 6, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants