Improve resilience to precision loss - #5109
Merged
Merged
Conversation
jngrad
force-pushed
the
precision
branch
2 times, most recently
from
July 8, 2025 18:23
24ebd64 to
a7d55cb
Compare
Member
Author
|
The waLBerla bridge is now tested on ARM. That wasn't possible before due to a long-standing round-off bug in the histogram class (logfile 45562052553) that use to trigger a write past-the-end in LB profile observables. |
reinaual
reviewed
Jul 9, 2025
jngrad
force-pushed
the
precision
branch
2 times, most recently
from
July 9, 2025 12:42
34b2bec to
5d9b5ba
Compare
reinaual
requested changes
Jul 9, 2025
Co-authored-by: Alexander Reinauer <areinauer@icp.uni-stuttgart.de>
reinaual
reviewed
Jul 9, 2025
reinaual
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5108
Description of changes: