Messages, iOS, Locale

[jeroenpeters1986]

Hi, please don't mind the numerous commits, but in the end I did

Messages app

• Added specific app icons
  • calendar
  • facebook
  • hangouts
  • instagram
  • gmail
  • google home
  • mail
  • messenger
  • outlook mail
  • phone
  • skype
  • slack
  • sms message (or iMessage)
  • twitter
  • telegram
  • whatsapp
  • wordfeud
• Small layout 'fix' to not attach the icon button to the left side of the screen (give it a few pixels space)
• Added a notification icon for when there are unread messages (instead of the blinking MESSAGES)
• Added screenshots
  In the end I did not change the icons, as I mentioned somewhere else, because 'notifications' come in so many shapes, that the Envelope icon is just as good as a bell/bubble/phone+line icon.

iOS app

• Fixed music attributes
• Added new app-identifiers
• Added a Readme

Locale (nl_NL)

• Added translations for the Messages menu items

[gfwilliams]

Nice - thanks!

A few things though:

• Message widget: I thought in [Messages - Feature Request] - change the widget bar to an icon rather than flashing 'MESSAGES' #1033 we'd said the messages icon would be configurable? I guess we'll go with new new one and see if anyone complains.
• Translations: It doesn't matter right now, but I wouldn't add more translations in that file. I think you've seen Add Internationalisation to more apps #136 but that'd be the best way to handle translations going forward.
• Message icons: this is great - but I wouldn't bother adding functions like getFBImage - just put them inline. Each function takes a certain amount of RAM so in a way it's better to just have a single big function.

[jeroenpeters1986]

Thanks @gfwilliams and also thanks for the points. Must be the late nights working on it, it's very exciting for me to contribute to this platform. But you are right, I will reinstate the green-flashing messages too with a menu settings.
I'll also check #136 to see if I can manage that, maybe in a new app.
On the functions, I did create functions for the icons that I used more than once (FB is used for Facebook and for Messenger for example). I was used doing that from my python-coding experience, but I understand managing such a small device is somehow different. I will revert a few of them. Is the getMailIcon (used 4 times) also a good idea to "optimize", or also just place it inline?

[gfwilliams]

Now it's done, please don't worry about reinstating the flashing message icon! If someone complains we'll add the settings, but no point doing it before!

I did create functions for the icons that I used more than once

Ahh, sorry, yes, that's perfect then. I'd had a quick glance down the code and didn't see any other references. If you're using it multiple times then it definitely makes sense.