Open
Conversation
Makes it easier to track MSRV breaks
Not currently checked in, adding here ensures it wont be accidentally
- Remove unused `macro_use`
- Remove unused `std` feature - Switch to `core` implicit prelude
- Switch to `core` implicit prelude - Ensure `threads` activates `std`
Test all `no_std` compatible features
etemesi254
reviewed
May 21, 2025
Owner
There was a problem hiding this comment.
This makes us lose runtime detection so may be slower see docs on https://docs.rs/simd-adler32/latest/simd_adler32/
Any reason why it was removed
Owner
|
ping on comment above |
|
Seems abandoned, it would be extremely handy to have at the very least |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
no_stdSupport #263Solution
Refer to individual commits for further details
rust-version = "1.81.0"to all crates, making it easier to maintain MSRV going forward. Exact version chosen for compatibility withcore::error::Error.coreimplicit prelude instead of conditionally changing the prelude based on a possiblestdfeature. This makes migrating currentlystd-only features tono_stdeasier in the future.no_stdcompatible features, not just--no-default-features.zune-coreto allowserdefeature inno_stdzune-inflateto removestdfeature (unused)zune-jpegto removestdfeature (unused)zune-qoito removestdfeature (unused)zune-bmpto removestdfeature (unused), opting for addingstdfeature indev-dependenciesinsteadzune-gifno_std(only minor changes required)zune-jpegxlto explicitly requirestdin thethreadsfeature