Skip to content

no_std Tidy-up#264

Open
bushrat011899 wants to merge 12 commits intoetemesi254:devfrom
bushrat011899:no_std_initial
Open

no_std Tidy-up#264
bushrat011899 wants to merge 12 commits intoetemesi254:devfrom
bushrat011899:no_std_initial

Conversation

@bushrat011899
Copy link

Objective

Solution

Refer to individual commits for further details

  • Added rust-version = "1.81.0" to all crates, making it easier to maintain MSRV going forward. Exact version chosen for compatibility with core::error::Error.
  • Switched to core implicit prelude instead of conditionally changing the prelude based on a possible std feature. This makes migrating currently std-only features to no_std easier in the future.
  • Updated CI to test all no_std compatible features, not just --no-default-features.
  • Updated zune-core to allow serde feature in no_std
  • Updated zune-inflate to remove std feature (unused)
  • Updated zune-jpeg to remove std feature (unused)
  • Updated zune-qoi to remove std feature (unused)
  • Updated zune-bmp to remove std feature (unused), opting for adding std feature in dev-dependencies instead
  • Made zune-gif no_std (only minor changes required)
  • Updated zune-jpegxl to explicitly require std in the threads feature

Makes it easier to track MSRV breaks
Not currently checked in, adding here ensures it wont be accidentally
- Remove `std` feature as no longer required
- Allow `serde` feature on `no_std`
- Switch to `core` implicit prelude
- Remove unused `macro_use`
- Add `no_std` support
- Remove unused `std` feature
- Switch to `core` implicit prelude
- Remove `std` feature as no longer used
- Switch to `core` implicit prelude
- Switch to `core` implicit prelude
- Ensure `threads` activates `std`
- Switch to `core` implicit prelude
- Remove unused `std` feature
Test all `no_std` compatible features
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes us lose runtime detection so may be slower see docs on https://docs.rs/simd-adler32/latest/simd_adler32/

Any reason why it was removed

@etemesi254
Copy link
Owner

ping on comment above

@CompeyDev
Copy link

Seems abandoned, it would be extremely handy to have at the very least core errors. It would also be worth using cpufeatures for runtime detections, instead of gating it purely behind std presence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants