Skip to content

Conversation

@Zverik
Copy link
Collaborator

@Zverik Zverik commented Dec 14, 2025

As it often happens, this pull request contains multiple fixes:

  1. Support for operators in the binding generator. Fixes Operator overrides cause binding to fail #252.
  2. Paths listed in analysis_options.yaml are now skipped by the bindgen (usually there is generated code that produces analysis errors).
  3. Skipping private fields and methods when generating bindings. Fixes Bindings generator adds bindings for private methods #256.
  4. Uri constructors now return Uri instances instead of strings.
  5. Added three failing tests for operator methods, for the time we implement those.
  6. Fixed for loops inside lists.
  7. Added context for some errors, so that it's easier to find the failing statement or a type reference.
  8. Fixed dart warnings, mainly from unnecessary labelling libraries.

@ethanblake4
Copy link
Owner

Appreciate this! Clearly the CI failure is not due to your changes but probably still needs to be resolved, will take a look shortly

@Zverik
Copy link
Collaborator Author

Zverik commented Dec 14, 2025

Thanks for noticing! I've fixed the analyzer error, but not sure how to proceed with the deprecation of RegExpMatch inheritance.

@ethanblake4
Copy link
Owner

I guess the simplest solution right now would be to implement Match instead of RegExpMatch. Or, you could just remove the implements altogether and all the overridden methods... This style of bimodal wrapper that implements the superclass is something I'm slowly sort-of getting rid of, it seems incompatible with the Dart language future vision.

@ethanblake4
Copy link
Owner

Fwiw, I have reviewed the other changes and they are looking good.

I have a little bit of relucatance about adding additional dependencies, but I think glob is probably fine since it is from the Dart team. However, please be judicious about adding dependencies in the future, it should only be done if they are absolutely needed.

@Zverik
Copy link
Collaborator Author

Zverik commented Dec 17, 2025

Fixed the RegExpMatch warning, and also fixed the Uri return types (just encountered that issue).

Regarding glob dependency, yes, I'm also wary of adding those, but I thought it's used by Dart and is pretty standard.

This was referenced Dec 17, 2025
@Zverik
Copy link
Collaborator Author

Zverik commented Dec 17, 2025

Uhm... I have also fixed the for operator, which failed on ForEachPart definition. Can I just merge it myself, or you wanna have another look?

@ethanblake4
Copy link
Owner

Can you please run dart format . before this and other commits? Pub will get mad and it's a bit hard to read

@Zverik
Copy link
Collaborator Author

Zverik commented Dec 17, 2025

Done :)

@Zverik Zverik merged commit f0fb7ec into ethanblake4:master Dec 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bindings generator adds bindings for private methods Operator overrides cause binding to fail

2 participants