Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventlogs to opentelemetry converter #23

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

yaitskov
Copy link

No description provided.

@yaitskov
Copy link
Author

grps is not supported on 8.10

@yaitskov
Copy link
Author

As of now I run out of ideas how to skip proto module for 8.10

@ethercrow
Copy link
Owner

Hopefully they will fix it at some point.

@yaitskov
Copy link
Author

yaitskov commented Jun 1, 2020

I hope so, but what about stack and cabal?
How many build system should be in a Haskell project to change a light bulb?
Could nix be rescue?

@yaitskov
Copy link
Author

yaitskov commented Jun 4, 2020

proto-lens ticket for support 8.10 is closed, nonetheless build is still failing.
Hackage version is not changed.
I tried to pull proto-lens dependency directly from a github branch,
but I don't see any difference in stack behavior.

I doubt that the snipped is working for packages already in Hackage.
How stack figures out that a git repo is for proto-lens?
Tries to prefetch? Imh it is error prone approach cause I could make type in subdirs.

- git: https://github.com/google/proto-lens
  commit 12312312312

@yaitskov
Copy link
Author

yaitskov commented Jun 4, 2020

I complete first version of OpenTelemetry translator and noticed mismatching between internal and OT structures: our event is (name, value, timestamp) but OT (name, attributes map <k,v>, ts)
so there is no obvious way for mapping. OT name could be fixed and name goes into attribute key
or vice versa.

@yaitskov
Copy link
Author

yaitskov commented Jun 5, 2020

@ethercrow , proto-lens issue is resolved.
Now build failing due git proto submodule is not fetched by CI.
I guess I need tweak following lines, but I don't see travis like file in the project.

git -c http.extraheader="AUTHORIZATION: basic ***" fetch --tags --prune --progress \
    --no-recurse-submodules origin +refs/heads/*:refs/remotes/origin/* \
    +refs/pull/23/merge:refs/remotes/pull/23/merge

@yaitskov yaitskov changed the title opentelemetry types and marshals eventlogs to opentelemetry converter Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants