proxyd: test regexp based UA/Origin exemptions #305
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asymmetric
force-pushed
the
push-zyvtswlzqnyo
branch
from
672a1cb to
54bbe28
Compare
|
/ci authorize 54bbe28 |
|
Hi @asymmetric , thank you for your PR. Would you mind rebasing and pushing it again, considering the current CI failures? |
asymmetric
force-pushed
the
push-zyvtswlzqnyo
branch
from
54bbe28 to
60b7c15
Compare
|
@yashvardhan-kukreja does the error mean I have to sign up for CircleCI? (Seems so) If so, I'm not super keen, to be honest.. sorry! |
|
Yep, that seems to be the access. Mind trying doing that out considering your user account being the trigger of this job? |
|
I've logged in/signed up with CircleCI, mind triggering the job again? |
asymmetric
force-pushed
the
push-zyvtswlzqnyo
branch
2 times, most recently
from
d96f794 to
3e3e1ad
Compare
asymmetric
force-pushed
the
push-zyvtswlzqnyo
branch
from
3e3e1ad to
2773a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the rate-limit integration test, switch to using a regexp exemption. This both tests the functionality, and serves as documentation surrogate (until the documentation itself mentions the
rate_limitblock).Tests
Changed the
testdataof therate_limit_test.Additional context
Add any other context about the problem you're solving.
Metadata