switch to gnark for bn254 curve operations #701
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks commit ethereum/go-ethereum@684b935, which is included in
gethv1.16.4. This changes the library used for bn254 curve operations fromcloudflaretognarkand greatly improves the execution performance of theECPAIRINGopcode, leading to >50% increased execution throughput on World Chain Mainnet.Tests
All tests were unchanged and pass. I've additionally been running this fork for multiple World Chain Mainnet node configurations (path-based full, path-based archive, hash-based archive) and all have worked with no issues.
Additional context
While this change will be included when
op-gethmergesgethv1.16.4, this allows the performance benefits of this change to be applied much sooner. Because this is the exact change used ingeth, it won't cause any issues merging v1.16.4 later on.