Use vm.prank(address,bool) for delegateCall, remove DelegateCaller contract #18331
+65
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurelian
force-pushed
the
jm/rm-dcforward
branch
from
c200575 to
047fc5f
Compare
was expecting foundry to override the CALL to a delegatcall for some reason.
maurelian
force-pushed
the
jm/rm-dcforward
branch
from
7c3d72d to
4c9b710
Compare
maurelian
added
the
force-use-fresh-artifacts
maurelian
force-pushed
the
jm/rm-dcforward
branch
from
de18884 to
ed9fcd6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18331 +/- ##
===========================================
+ Coverage 74.91% 79.77% +4.86%
===========================================
Files 181 126 -55
Lines 10930 6899 -4031
===========================================
- Hits 8188 5504 -2684
+ Misses 2598 1395 -1203
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Adds a prankDelegateCall() helper function to eliminate repetitive code pattern for handling Foundry's requirement that addresses have at least one byte of code to prank delegatecalls. This helper combines vm.etch() and vm.prank(_, true) into a single reusable function.
maurelian
force-pushed
the
jm/rm-dcforward
branch
from
ed9fcd6 to
fb6c122
Compare
Contributor
Author
|
Keeping in draft so as not to block #18079. |
Prevents merge conflicts with other inflight work
maurelian
commented
Nov 21, 2025
| vm.etch(_caller, hex"00"); | ||
| } | ||
| vm.prank(_caller, true); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I created this as a free function here because I couldn't really find an appropriate place to put it, and it wasn't needed in ForkLive (the only other file that used DelegateCaller).
I could move it into CommonTest if preferred, but it doesn't quite match the nature of the existing functions there.
Member
There was a problem hiding this comment.
I am fine with having it here as I dont know where I would put it
JosepBove
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the usage of DelegateCaller. The pattern established is much nicer.
However DelegateCaller is not deleted here, so as not to conflict with #18079 which makes use of it.