Skip to content

opcm: break v1 to see what else breaks #18387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
maurelian wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

opcm: break v1 to see what else breaks #18387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f488371
opcm: break v1 to see what else breaks
maurelian Nov 26, 2025
457e7da
allow warnings
maurelian Nov 26, 2025
190ad31
Allow warnings in other places
maurelian Nov 26, 2025
f5e2e58
update snapshots
maurelian Nov 26, 2025
be10f0d
Add FAILURES.md
maurelian Nov 26, 2025
e9368c5
fix Failures formatting
maurelian Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2525,7 +2525,7 @@ workflows:
- contracts-bedrock-build:
name: contracts-bedrock-build
# Build with just core + script contracts.
build_args: --deny-warnings --skip test
build_args: --skip test
context:
- circleci-repo-readonly-authenticated-github-token
- check-kontrol-build:
Expand Down Expand Up @@ -2987,7 +2987,7 @@ workflows:
- slack
- circleci-repo-readonly-authenticated-github-token
- contracts-bedrock-build:
build_args: --deny-warnings --skip test
build_args: --skip test
context:
- slack
- circleci-repo-readonly-authenticated-github-token
Expand Down Expand Up @@ -3036,7 +3036,7 @@ workflows:
- equal: [true, << pipeline.parameters.cannon_full_test_dispatch >>]
jobs:
- contracts-bedrock-build:
build_args: --deny-warnings --skip test
build_args: --skip test
context:
- circleci-repo-readonly-authenticated-github-token
- cannon-go-lint-and-test:
Expand Down
31 changes: 31 additions & 0 deletions FAILURES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
Some checks were not successful
0 cancelled, 27 failing, 53 successful, 0 skipped, and 0 pending checks

NAME DESCRIPTION ELAPSED URL
X Code Review Requirements https://circleci.com/gh/ethereum-optimism/github-governance...
X acceptance-tests 18m14s https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/108681/workflows/30647162-ee0d-46de-9708-22d2cca34fa0/jobs/4132414
X ci/circleci: check-kontrol-build Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132373
X ci/circleci: contracts-bedrock-checks Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132387
X ci/circleci: contracts-bedrock-coverage CANNON_KONA,DEPLOY_... Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132406
X ci/circleci: contracts-bedrock-coverage CUSTOM_GAS_TOKEN Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132367
X ci/circleci: contracts-bedrock-coverage OPCM_V2 Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132392
X ci/circleci: contracts-bedrock-coverage OPTIMISM_PORTAL_INT... Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132366
X ci/circleci: contracts-bedrock-coverage main Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132346
X ci/circleci: contracts-bedrock-tests CANNON_KONA,DEPLOY_V2_... Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132369
X ci/circleci: contracts-bedrock-tests CUSTOM_GAS_TOKEN Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132349
X ci/circleci: contracts-bedrock-tests OPCM_V2 Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132403
X ci/circleci: contracts-bedrock-tests OPTIMISM_PORTAL_INTEROP Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132405
X ci/circleci: contracts-bedrock-tests main Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132364
X ci/circleci: contracts-bedrock-tests-upgrade base-mainnet Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132360
X ci/circleci: contracts-bedrock-tests-upgrade ink-mainnet Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132408
X ci/circleci: contracts-bedrock-tests-upgrade op-mainnet CAN... Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132397
X ci/circleci: contracts-bedrock-tests-upgrade op-mainnet CUS... Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132347
X ci/circleci: contracts-bedrock-tests-upgrade op-mainnet OPC... Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132354
X ci/circleci: contracts-bedrock-tests-upgrade op-mainnet OPT... Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132350
X ci/circleci: contracts-bedrock-tests-upgrade op-mainnet main Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132345
X ci/circleci: contracts-bedrock-tests-upgrade unichain-mainnet Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132356
X ci/circleci: go-tests-short Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132388
X ci/circleci: memory-all Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132414
X ci/circleci: op-e2e-fuzz Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132383
X ci/circleci: semgrep-scan-local Your tests failed on CircleCI https://circleci.com/gh/ethereum-optimism/optimism/4132400
X main 13m35s https://app.circleci.com/pipelines/github/ethereum-optimism...
2 changes: 1 addition & 1 deletion op-fetcher/justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ build-contracts:
mkdir -p ./pkg/fetcher/fetch/forge-artifacts
cd ../packages/contracts-bedrock
just clean
just build-dev --deny-warnings --skip test
just build-dev --skip test
cp -r forge-artifacts/FetchChainInfo.s.sol ../../op-fetcher/pkg/fetcher/fetch/forge-artifacts
2 changes: 1 addition & 1 deletion packages/contracts-bedrock/foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ fs_permissions = [

# 5159 error code is selfdestruct error code
ignored_error_codes = ["transient-storage", "code-size", "init-code-size", "too-many-warnings", 5159]
deny_warnings = true
# deny_warnings = true
ffi = true

# We set the gas limit to max int64 to avoid running out of gas during testing, since the default
Expand Down
Loading