-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat: add OPCMv2 tests for existing behaviors #18389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+335
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18389 +/- ##
===========================================
+ Coverage 75.60% 79.72% +4.12%
===========================================
Files 187 132 -55
Lines 11199 7168 -4031
===========================================
- Hits 8467 5715 -2752
+ Misses 2586 1453 -1133
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
0xiamflux
reviewed
Nov 26, 2025
packages/contracts-bedrock/test/L1/opcm/OPContractsManagerContainer.t.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/test/L1/opcm/OPContractsManagerContainer.t.sol
Show resolved
Hide resolved
packages/contracts-bedrock/test/L1/opcm/OPContractsManagerContainer.t.sol
Show resolved
Hide resolved
maurelian
reviewed
Dec 1, 2025
packages/contracts-bedrock/test/L1/opcm/OPContractsManagerContainer.t.sol
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM |
maurelian
approved these changes
Dec 1, 2025
JosepBove
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests for AddGameType and UpdatePrestate behaviors in OPCMv2. It also adds tests for OPContractsManagerContainer (the new version).