Skip to content

Conversation

@ajsutton
Copy link
Contributor

Description

We shouldn't need two reviews to change the abi loading code (which has to be in packages/contracts-bedrock due to Go's rules around embedding content). And it should be approved by go reviewers, not contract reviewers.

@ajsutton ajsutton requested a review from a team as a code owner November 27, 2025 02:39
@ajsutton ajsutton requested a review from mds1 November 27, 2025 02:39
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.31%. Comparing base (5f1dcbc) to head (bd2a86e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18394      +/-   ##
===========================================
- Coverage    75.60%   75.31%   -0.30%     
===========================================
  Files          187      187              
  Lines        11199    11199              
===========================================
- Hits          8467     8434      -33     
- Misses        2586     2621      +35     
+ Partials       146      144       -2     
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (-0.82%) ⬇️
contracts-bedrock-tests 80.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants