Fulu: Remove V3 of blob sidecar by root/range RPC #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Fulu fork introduces peerDAS, replacing blobs sidecars by data columns sidecars. After the Fulu fork epoch, clients still need to be able to request blob sidecars by root/range, at least for the blobs retention period after the Fulu fork epoch. Blob sidecars will be retrieved at most up to the Electra epoch, so the V2 version (Electra) for blob sidecars by range/root is enough. There is no need to retrieve blobs sidecars after the Fulu fork where data columns sidecars will be used instead, so there is no need to introduce the V3 version (Fulu) for blob sidecars by range/root.
ppopth
approved these changes
Jan 7, 2025
|
Nice catch! and thanks for the PR |
hwwhww
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
discussed and approved via the PeerDAS breakout room today (ethereum/pm#1236). 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Fulu fork introduces peerDAS, replacing blob sidecars by data columns sidecars.
After the Fulu fork epoch, clients still need to be able to request blob sidecars by root/range, at least for the blobs retention period after the Fulu fork epoch.
Blob sidecars will be retrieved at most up to the Electra epoch, so the V2 version (Electra) for blob sidecars by range/root is enough. There is no need to retrieve blob sidecars after the Fulu fork where data column sidecars will be used instead, so there is no need to introduce the V3 version (Fulu) for blob sidecars by range/root.