-
Notifications
You must be signed in to change notification settings - Fork 5.2k
docs: minor-styling #16109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pete-vielhaber
wants to merge
5
commits into
ethereum:dev
Choose a base branch
from
pete-vielhaber:patch-2
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−29
Open
docs: minor-styling #16109
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ede5108
Update index.md
pete-vielhaber f3a9ed3
adding hardstops to i.e. for consistency against e.g.,; also adding s…
pete-vielhaber d62f695
adding hardstops to e.g. for consistency across pages
pete-vielhaber 1734ff7
changed our to the to divert ownership away from EF for Lodestar
pete-vielhaber 056834c
adding hardstops for consistency across pages
pete-vielhaber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,7 +46,7 @@ _Diagram data from [ethernodes.org](https://ethernodes.org) and [clientdiversity | |
|
||
The two pie charts above show snapshots of the current client diversity for the execution and consensus layers (at time of writing in January 2022). The execution layer is overwhelmingly dominated by [Geth](https://geth.ethereum.org/), with [Open Ethereum](https://openethereum.github.io/) a distant second, [Erigon](https://github.com/ledgerwatch/erigon) third and [Nethermind](https://nethermind.io/) fourth, with other clients comprising less than 1 % of the network. The most commonly used client on the consensus layer - [Prysm](https://prysmaticlabs.com/#projects) - is not as dominant as Geth but still represents over 60% of the network. [Lighthouse](https://lighthouse.sigmaprime.io/) and [Teku](https://consensys.net/knowledge-base/ethereum-2/teku/) make up ~20% and ~14% respectively, and other clients are rarely used. | ||
|
||
The execution layer data were obtained from [Ethernodes](https://ethernodes.org) on 23-Jan-2022. Data for consensus clients was obtained from [Michael Sproul](https://github.com/sigp/blockprint). Consensus client data is more difficult to obtain because the consensus layer clients do not always have unambiguous traces that can be used to identify them. The data was generated using a classification algorithm that sometimes confuses some of the minority clients (see [here](https://twitter.com/sproulM_/status/1440512518242197516) for more details). In the diagram above, these ambiguous classifications are treated with an either/or label (e.g. Nimbus/Teku). Nevertheless, it is clear that the majority of the network is running Prysm. The data is a snapshot over a fixed set of blocks (in this case Beacon blocks in slots 2048001 to 2164916) and Prysm's dominance has sometimes been higher, exceeding 68%. Despite only being snapshots, the values in the diagram provide a good general sense of the current state of client diversity. | ||
The execution layer data were obtained from [Ethernodes](https://ethernodes.org) on 23-Jan-2022. Data for consensus clients was obtained from [Michael Sproul](https://github.com/sigp/blockprint). Consensus client data is more difficult to obtain because the consensus layer clients do not always have unambiguous traces that can be used to identify them. The data was generated using a classification algorithm that sometimes confuses some of the minority clients (see [here](https://twitter.com/sproulM_/status/1440512518242197516) for more details). In the diagram above, these ambiguous classifications are treated with an either/or label (e.g., Nimbus/Teku). Nevertheless, it is clear that the majority of the network is running Prysm. The data is a snapshot over a fixed set of blocks (in this case Beacon blocks in slots 2048001 to 2164916) and Prysm's dominance has sometimes been higher, exceeding 68%. Despite only being snapshots, the values in the diagram provide a good general sense of the current state of client diversity. | ||
|
||
Up to date client diversity data for the consensus layer is now available at [clientdiversity.org](https://clientdiversity.org/). | ||
|
||
|
@@ -60,29 +60,29 @@ Addressing client diversity requires more than individual users to choose minori | |
|
||
### Execution clients {#execution-clients} | ||
|
||
[Besu](https://www.hyperledger.org/use/besu) | ||
- [Besu](https://www.hyperledger.org/use/besu) | ||
|
||
[Nethermind](https://downloads.nethermind.io/) | ||
- [Nethermind](https://downloads.nethermind.io/) | ||
|
||
[Erigon](https://github.com/ledgerwatch/erigon) | ||
- [Erigon](https://github.com/ledgerwatch/erigon) | ||
|
||
[Go-Ethereum](https://geth.ethereum.org/) | ||
- [Go-Ethereum](https://geth.ethereum.org/) | ||
|
||
[Reth](https://reth.rs/) | ||
- [Reth](https://reth.rs/) | ||
|
||
### Consensus clients {#consensus-clients} | ||
|
||
[Nimbus](https://nimbus.team/) | ||
- [Nimbus](https://nimbus.team/) | ||
|
||
[Lighthouse](https://github.com/sigp/lighthouse) | ||
- [Lighthouse](https://github.com/sigp/lighthouse) | ||
|
||
[Teku](https://consensys.net/knowledge-base/ethereum-2/teku/) | ||
- [Teku](https://consensys.net/knowledge-base/ethereum-2/teku/) | ||
|
||
[Lodestar](https://github.com/ChainSafe/lodestar) | ||
- [Lodestar](https://github.com/ChainSafe/lodestar) | ||
|
||
[Prysm](https://docs.prylabs.network/docs/getting-started) | ||
- [Prysm](https://docs.prylabs.network/docs/getting-started) | ||
|
||
[Grandine](https://docs.grandine.io/) | ||
- [Grandine](https://docs.grandine.io/) | ||
Comment on lines
+63
to
+85
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lgtm, could clean up the whitespace between these as well as we typically write lists without empty lines between... will render the same, so just a small nit-pick |
||
|
||
Technical users can help accelerate this process by writing more tutorials and documentation for minority clients and encouraging their node-operating peers to migrate away from the dominant clients. Guides for switching to a minority consensus client are available on [clientdiversity.org](https://clientdiversity.org/). | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a trailing period for this feels a bit strange when it's broken out, no? Thoughts on removing to just:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Similar to the
More information can be found on the [Lodestar website](https://lodestar.chainsafe.io/)
line updated below)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was comparing against other pages that have periods at the end of these More on [topic]. Suggestion was more for consistency than anything.