-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(tests): EOF - EIP-7620: EOFCREATE
and RETURNCONTRACT
container validation tests
#640
base: main
Are you sure you want to change the base?
Conversation
a3058fc
to
a7d8f3d
Compare
a7d8f3d
to
ffa3b57
Compare
@shemnon @chfast currently the following code validation test cases are failing with evmone:
The test cases seem to be following the spec but let me know if I could be missing something. |
Spec was updated. If we had versioning turned on we could have added a version bump to that update and tooling could have caught it. |
@marioevz, this change is not in evmone's |
@marioevz this change has landed in evmone |
ExceptionMessage( | ||
EOFException.TOPLEVEL_CONTAINER_TRUNCATED, "err: toplevel_container_truncated" | ||
), | ||
ExceptionMessage(EOFException.INVALID_MAX_STACK_HEIGHT), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so what this maps to? "eofexception.invalid_max_stack_height"?
ποΈ Description
Adds container validation tests for cases when the
EOFCREATE
andRETURNCONTRACT
opcodes are misused.π Related Issues
None
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.