feat: implement eip-7951 #1249
Closed
feat: implement eip-7951 #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
| @@ -54,7 +54,7 @@ def ecrecover(evm: Evm) -> None: | |||
|
|
|||
| try: | |||
| public_key = secp256k1_recover(r, s, v - U256(27), message_hash) | |||
| except InvalidSignatureError: | |||
| except Exception: | |||
There was a problem hiding this comment.
I feel like we could use specific exceptions here, given secp256k1_recover method raises a kind of InvalidSignatureError?
Merged
|
This PR could be closed, since there are rebase issue with this branch, we migrate the changes to PR #1291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1244
How was it fixed?
Implement EIP-7212
New python package added:
pycryptodomeandcryptographyCute Animal Picture